Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests of "withSequence" and clean up imports #6050

Merged
merged 10 commits into from
Jun 24, 2024
Merged

Add tests of "withSequence" and clean up imports #6050

merged 10 commits into from
Jun 24, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented May 27, 2024 •
edited
Loading

Summary

Add tests of withSequence and clean up the import structure of tests

Test plan

@Latropos Latropos marked this pull request as ready for review June 18, 2024 15:32
@Latropos Latropos changed the title Add tests of "withSequence" Add tests of "withSequence" and clean up imports Jun 18, 2024
latekvo
latekvo reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@latekvo latekvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just those 2 minor questions.

apps/common-app/src/examples/RuntimeTests/tests/animations/withSequence/arrays.test.tsx Show resolved Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withSequence/colors.test.tsx Outdated Show resolved Hide resolved
piaskowyk
piaskowyk reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very solid 👍

apps/common-app/src/examples/RuntimeTests/tests/animations/withSequence/arrays.test.tsx Outdated Show resolved Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/index.tsx Show resolved Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withSequence/arrays.test.tsx Show resolved Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withSequence/colors.test.tsx Show resolved Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withSequence/colors.test.tsx Show resolved Hide resolved
@Latropos Latropos requested a review from piaskowyk June 24, 2024 08:46
@Latropos Latropos enabled auto-merge June 24, 2024 11:24
@Latropos Latropos added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 49a6882 Jun 24, 2024
5 checks passed
@Latropos Latropos deleted the acynk/test-with-sequence branch June 24, 2024 12:04
@arenault-pass arenault-pass mentioned this pull request Jul 25, 2024
Closed
This was referenced Jul 25, 2024
Open
Open
@sonlast sonlast mentioned this pull request Jul 27, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Jul 29, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 1, 2024
Closed
@phucle1010 phucle1010 mentioned this pull request Aug 1, 2024
Open
@tiago002pro tiago002pro mentioned this pull request Aug 5, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 12, 2024
Open
@waveyboym waveyboym mentioned this pull request Aug 19, 2024
Closed
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 24, 2024
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Aug 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latekvo latekvo latekvo approved these changes

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Latropos @piaskowyk @latekvo