Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add contributing docs page #6061

Merged
merged 32 commits into from
Jun 17, 2024
Merged

docs: add contributing docs page #6061

merged 32 commits into from
Jun 17, 2024

Conversation

maciekstosio
Copy link
Contributor

@maciekstosio maciekstosio commented May 29, 2024 •
edited by kacperkapusciak
Loading

Contributing guide page in docs describing how to start contributing to Reanimated library.

@kacperkapusciak kacperkapusciak changed the title [WIP] Add contributing docs page Add contributing docs page Jun 13, 2024
@kacperkapusciak kacperkapusciak marked this pull request as ready for review June 13, 2024 07:55
@kacperkapusciak kacperkapusciak changed the title Add contributing docs page docs: add contributing docs page Jun 13, 2024
patrycjakalinska
patrycjakalinska requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@patrycjakalinska patrycjakalinska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link in a codeblock needs changing, eveything else is okay 🚀

packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
szydlovsky
szydlovsky requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being a grammar nazi but I believe we could make the page much more professional with top-knotch spelling and grammar :shipit::shipit::shipit:

packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
patrycjakalinska
patrycjakalinska approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@patrycjakalinska patrycjakalinska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

szydlovsky
szydlovsky approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exquisite :shipit: 👍

@maciekstosio maciekstosio added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit d469392 Jun 17, 2024
6 checks passed
@maciekstosio maciekstosio deleted the @maciekstosio/Contributing-docs-page branch June 17, 2024 13:48
@arenault-pass arenault-pass mentioned this pull request Jul 25, 2024
Closed
This was referenced Jul 25, 2024
Open
Open
@sonlast sonlast mentioned this pull request Jul 27, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Jul 29, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 1, 2024
Closed
@phucle1010 phucle1010 mentioned this pull request Aug 1, 2024
Open
@tiago002pro tiago002pro mentioned this pull request Aug 5, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 12, 2024
Open
@waveyboym waveyboym mentioned this pull request Aug 19, 2024
Closed
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 24, 2024
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Aug 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szydlovsky szydlovsky szydlovsky approved these changes

@patrycjakalinska patrycjakalinska patrycjakalinska approved these changes

@kacperkapusciak kacperkapusciak kacperkapusciak approved these changes

@piaskowyk piaskowyk piaskowyk approved these changes

@tomekzaw tomekzaw Awaiting requested review from tomekzaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maciekstosio @piaskowyk @kacperkapusciak @patrycjakalinska @szydlovsky