Enable -Wpedantic flag on Android and use std::vector instead of VLA to pass arguments to _scheduleOnJS
#6157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VLA to pass arguments to `_scheduleOnJS`
piaskowyk
approved these changes
Jun 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary This PR temporarily fixes #6234 by making the problematic `-Wpedantic` flag to be applied only in Reanimated example apps so that we can monitor the soundness of the code on the CI. `-Wpedantic` flag was introduced in #6157 and released in 3.13.0. ## Test plan Check if the CI is green.
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just wanted to enable
-Wpedanticflag on Android like React Native does.Test plan
Tested on runOnUI / runOnJS example.