Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web LA] Fix chrome flickers #6172

Merged
merged 3 commits into from
Jul 1, 2024
Merged

[Web LA] Fix chrome flickers #6172

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d412a41
Fix chrome flickers
m-bert Jun 26, 2024
b61d796
Use raf only on entering
m-bert Jul 1, 2024
9a3ec76
Add comment
m-bert Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions packages/react-native-reanimated/src/layoutReanimation/web/componentUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,20 @@ export function setElementAnimation(
) {
const { animationName, duration, delay, easing } = animationConfig;

element.style.animationName = animationName;
element.style.animationDuration = `${duration}s`;
element.style.animationDelay = `${delay}s`;
element.style.animationTimingFunction = easing;
const configureAnimation = () => {
element.style.animationName = animationName;
element.style.animationDuration = `${duration}s`;
element.style.animationDelay = `${delay}s`;
element.style.animationTimingFunction = easing;
};

if (animationConfig.animationType === LayoutAnimationType.ENTERING) {
// On chrome sometimes entering animations flicker. This is most likely caused by animation being interrupted
// by already started tasks. To avoid flickering, we use `requestAnimationFrame`, which will run callback right before repaint.
requestAnimationFrame(configureAnimation);
} else {
configureAnimation();
}

element.onanimationend = () => {
if (shouldSavePosition) {
Expand Down