Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Layout Transition with size change #6178

Merged
merged 9 commits into from
Jul 31, 2024
Merged

Test Layout Transition with size change #6178

merged 9 commits into from
Jul 31, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Jun 27, 2024 •
edited
Loading

Summary

Tests added in PR: #6168
verify layout transition of component changing position only. In this PR I verify cases when both position and size change.

Test plan

image

@Latropos Latropos marked this pull request as ready for review June 27, 2024 15:34
@Latropos Latropos changed the title Layout with size Test Layout Transition with size change Jun 27, 2024
Base automatically changed from acynk/layout to main June 28, 2024 10:50
@Latropos Latropos requested a review from piaskowyk June 28, 2024 12:02
piaskowyk
piaskowyk reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of it seems to be fine, but lets wait until #6174 will be merged

packages/react-native-reanimated/src/layoutReanimation/defaultTransitions/FadingTransition.ts Outdated Show resolved Hide resolved
@Latropos Latropos marked this pull request as draft July 10, 2024 09:33
@Latropos Latropos requested a review from piaskowyk July 29, 2024 14:41
@Latropos Latropos marked this pull request as ready for review July 29, 2024 14:42
@Latropos Latropos requested a review from piaskowyk July 31, 2024 08:10
@Latropos Latropos added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 5a3855a Jul 31, 2024
5 checks passed
@Latropos Latropos deleted the acynk/entry-exit-transitions branch July 31, 2024 10:35
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 28, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 28, 2024
Closed
@jaydenchee97 jaydenchee97 mentioned this pull request Aug 28, 2024
Open
@azu-josh azu-josh mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 29, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 6, 2024
Closed
@mhmoudmhmed mhmoudmhmed mentioned this pull request Sep 7, 2024
Open
This was referenced Sep 7, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Sep 24, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 24, 2024
Closed
This was referenced Sep 24, 2024
Open
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 25, 2024
Closed
Closed
Closed
@ananichoumchoum ananichoumchoum mentioned this pull request Sep 27, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 28, 2024
Closed
@yingbull yingbull mentioned this pull request Sep 28, 2024
Closed
@manh20012000 manh20012000 mentioned this pull request Sep 29, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@manh20012000 manh20012000 mentioned this pull request Oct 1, 2024
Open
This was referenced Oct 1, 2024
Closed
Closed
@WontonSam WontonSam mentioned this pull request Oct 2, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 3, 2024
Closed
Closed
This was referenced Oct 4, 2024
Closed
Closed
This was referenced Oct 5, 2024
Closed
Closed
@kabir0x23 kabir0x23 mentioned this pull request Oct 28, 2024
Closed
@yingbull yingbull mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Latropos @piaskowyk