Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend plugin's documentation #6227

Merged
merged 8 commits into from
Jul 15, 2024
Merged

Extend plugin's documentation #6227

merged 8 commits into from
Jul 15, 2024

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Jul 8, 2024

Since the number of features in Reanimated Babel Plugin grows it would be decent to have them nicely documented.

As a bonus plugin becomes a separate workspace - it was overlooked during the monorepo migration.

patrycjakalinska
patrycjakalinska approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@patrycjakalinska patrycjakalinska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspiring ✨

packages/docs-reanimated/docs/reanimated-babel-plugin/about.md Outdated Show resolved Hide resolved
@kacperkapusciak kacperkapusciak self-requested a review July 8, 2024 10:15
@tjzel tjzel added the Area: Documentation Documentation change/enhancement will likely prevent people from encountering this problem label Jul 8, 2024
kacperkapusciak
kacperkapusciak requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Finally a place where its all collected and described 🎖️

Left a couple of comments but overall I'm very happy about it!

packages/docs-reanimated/docs/reanimated-babel-plugin/about.md Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/reanimated-babel-plugin/about.md Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/reanimated-babel-plugin/about.md Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/reanimated-babel-plugin/about.md Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/reanimated-babel-plugin/about.md Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/reanimated-babel-plugin/about.md Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/reanimated-babel-plugin/about.md Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/reanimated-babel-plugin/about.md Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/reanimated-babel-plugin/about.md Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/reanimated-babel-plugin/about.md Outdated Show resolved Hide resolved
kacperkapusciak
kacperkapusciak approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

@tjzel tjzel added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 2d0ed0b Jul 15, 2024
8 checks passed
@tjzel tjzel deleted the @tjzel/plugin/extend-docs branch July 15, 2024 14:04
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 28, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 28, 2024
Closed
@jaydenchee97 jaydenchee97 mentioned this pull request Aug 28, 2024
Open
@azu-josh azu-josh mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 29, 2024
Open
@Bonnie-TJ Bonnie-TJ mentioned this pull request Sep 4, 2024
Merged
This was referenced Sep 24, 2024
Open
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 25, 2024
Closed
Closed
Closed
@ananichoumchoum ananichoumchoum mentioned this pull request Sep 27, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 28, 2024
Closed
@yingbull yingbull mentioned this pull request Sep 28, 2024
Closed
@manh20012000 manh20012000 mentioned this pull request Sep 29, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@manh20012000 manh20012000 mentioned this pull request Oct 1, 2024
Open
This was referenced Oct 1, 2024
Closed
Closed
@WontonSam WontonSam mentioned this pull request Oct 2, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 3, 2024
Closed
Closed
This was referenced Oct 4, 2024
Closed
Closed
This was referenced Oct 5, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Oct 25, 2024
Open
@kabir0x23 kabir0x23 mentioned this pull request Oct 28, 2024
Closed
@yingbull yingbull mentioned this pull request Oct 28, 2024
Closed
@phucle1010 phucle1010 mentioned this pull request Nov 1, 2024
Open
@Abyss0108 Abyss0108 mentioned this pull request Nov 3, 2024
Open
@kabir0x23 kabir0x23 mentioned this pull request Nov 4, 2024
Closed
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Nov 5, 2024
Open
@edwardsph edwardsph mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrycjakalinska patrycjakalinska patrycjakalinska approved these changes

@jakub-gonet jakub-gonet jakub-gonet left review comments

@szydlovsky szydlovsky szydlovsky approved these changes

@kacperkapusciak kacperkapusciak kacperkapusciak approved these changes

@bartlomiejbloniarz bartlomiejbloniarz Awaiting requested review from bartlomiejbloniarz

Assignees
No one assigned
Labels
Area: Documentation Documentation change/enhancement will likely prevent people from encountering this problem Area: Plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tjzel @jakub-gonet @kacperkapusciak @patrycjakalinska @szydlovsky