[reJest] waitForAnimationUpdates #6236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latropos
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Looks good!
However I suppose that waitForAnimationUpdates(snapshot.length) allows more flexibility.
For example we sometimes want to check that concatenation of snapshots of Animation_A and Animation_B matches the snapshot of withSequence(Animation_A, Animation_B).
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/TestRunner.ts
Outdated
Show resolved
Hide resolved
Latropos
reviewed
Jul 9, 2024
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/TestRunner.ts
Show resolved
Hide resolved
Latropos
approved these changes
Jul 16, 2024
This was referenced Sep 7, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
This was referenced Oct 3, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a new method to the runtime test API -
waitForAnimationUpdates. The method accepts the expected snapshot of the animation and waits until it receives the exact amount of JS updates defined in the snapshot.