-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement toThrow #6267
Merged
Merged
Implement toThrow #6267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
reviewed
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/matchers/rawMatchers.ts
Outdated
Show resolved
Hide resolved
piaskowyk
reviewed
Jul 30, 2024
apps/common-app/src/examples/RuntimeTests/ReJest/matchers/rawMatchers.ts
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReJest/matchers/rawMatchers.ts
Show resolved
Hide resolved
piaskowyk
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be ok, but lets remove duplicated mockConsole
in the next PR
This was referenced Sep 7, 2024
This was referenced Sep 24, 2024
This was referenced Oct 4, 2024
This was referenced Oct 17, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the future the matcher
toThrow
should replace .FAILING and .WARNING test decorators.It allows more flexibility, as it is easy to add .not modificator and test that given code doesn't throw unexpected errors.
Test plan