-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workletizable Context Objects #6284
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
force-pushed
the
@tjzel/plugin/context-objects
branch
from
July 17, 2024 12:20
2717279
to
ce914e6
Compare
bartlomiejbloniarz
approved these changes
Jul 17, 2024
apps/common-app/src/examples/RuntimeTests/tests/plugin/contextObjects.test.tsx
Show resolved
Hide resolved
This was referenced Sep 7, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
This was referenced Oct 3, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the concept of Context Objects on the Worklet Runtime.
What?
Context Object is a shareable object that doesn't lose its
this
binding when it goes to the Worklet Runtime. To define an object as a Context Object, the user has to define property__workletContextObject
on it. The value of this property doesn't matter.Context Objects are also auto-detected when Babel processes files marked with a worklet directive. If a top level object has a method that references
this
inside we treat is as a Context Object.Why?
Currently it's not possible to refer to an object's methods from its other methods.
How?
Context Objects are handled as another type of shareable entity on the React Runtime.
__workletObjectFactory
to Context Objects. It's a function that creates an identical object.Test plan