Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Split cpp code base #6329

Merged
merged 2 commits into from
Jul 25, 2024
Merged

refactor: Split cpp code base #6329

merged 2 commits into from
Jul 25, 2024

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Jul 24, 2024 •
edited
Loading

Summary

This pull requests defines boundaries in C++ layer between Worklet Runtimes logic and Animations logic. I've only moved files here, more elaborate refactors will come up in the future.

Test plan

  • Android builds & runs.
  • iOS builds & runs.

@tjzel tjzel marked this pull request as ready for review July 25, 2024 07:56
@tjzel tjzel added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit dd2b9f8 Jul 25, 2024
12 checks passed
@tjzel tjzel deleted the @tjzel/worklets/split-cpp-code branch July 25, 2024 10:02
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 28, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 28, 2024
Closed
@jaydenchee97 jaydenchee97 mentioned this pull request Aug 28, 2024
Open
@azu-josh azu-josh mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 29, 2024
Open
@Bonnie-TJ Bonnie-TJ mentioned this pull request Sep 4, 2024
Merged
@tanyipeng834 tanyipeng834 mentioned this pull request Sep 4, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 6, 2024
Closed
@mhmoudmhmed mhmoudmhmed mentioned this pull request Sep 7, 2024
Open
This was referenced Sep 7, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Sep 24, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 24, 2024
Closed
This was referenced Sep 24, 2024
Open
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 25, 2024
Closed
Closed
@arenault-pass arenault-pass mentioned this pull request Sep 27, 2024
Closed
@ananichoumchoum ananichoumchoum mentioned this pull request Sep 27, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 28, 2024
Closed
@yingbull yingbull mentioned this pull request Sep 28, 2024
Closed
@manh20012000 manh20012000 mentioned this pull request Sep 29, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@manh20012000 manh20012000 mentioned this pull request Oct 1, 2024
Open
This was referenced Oct 1, 2024
Closed
Closed
@WontonSam WontonSam mentioned this pull request Oct 2, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 3, 2024
Closed
Closed
This was referenced Oct 4, 2024
Closed
Closed
This was referenced Oct 5, 2024
Closed
Closed
@renovate renovate bot mentioned this pull request Oct 17, 2024
Open
1 task
@phucle1010 phucle1010 mentioned this pull request Oct 25, 2024
Open
@kabir0x23 kabir0x23 mentioned this pull request Oct 28, 2024
Closed
@yingbull yingbull mentioned this pull request Oct 28, 2024
Closed
@phucle1010 phucle1010 mentioned this pull request Nov 1, 2024
Open
@Abyss0108 Abyss0108 mentioned this pull request Nov 3, 2024
Open
@kabir0x23 kabir0x23 mentioned this pull request Nov 4, 2024
Closed
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Nov 5, 2024
Open
@edwardsph edwardsph mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

@tomekzaw tomekzaw Awaiting requested review from tomekzaw

@bartlomiejbloniarz bartlomiejbloniarz Awaiting requested review from bartlomiejbloniarz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjzel @piaskowyk