Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pendulum example to not crash on empty mass input field #6379

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Fix pendulum example to not crash on empty mass input field #6379

merged 1 commit into from
Aug 6, 2024

Conversation

latekvo
Copy link
Contributor

@latekvo latekvo commented Aug 6, 2024

(cherry picked from commit 21967b1)

Summary

Inputting empty string into the mass field would crash the app on android.
This PR fixes this issue.

Test plan

  • open Pendulum example
  • switch to non-duration based config
  • delete all data from the mass input field

@latekvo latekvo requested a review from szydlovsky August 6, 2024 08:40
@latekvo latekvo marked this pull request as ready for review August 6, 2024 09:01
@latekvo latekvo added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit 1813ade Aug 6, 2024
6 checks passed
@latekvo latekvo deleted the @latekvo/fix-pendulum-example-crash branch August 6, 2024 09:02
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 28, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 28, 2024
Closed
@jaydenchee97 jaydenchee97 mentioned this pull request Aug 28, 2024
Open
@azu-josh azu-josh mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 29, 2024
Open
@Bonnie-TJ Bonnie-TJ mentioned this pull request Sep 4, 2024
Merged
@tanyipeng834 tanyipeng834 mentioned this pull request Sep 4, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 6, 2024
Closed
@mhmoudmhmed mhmoudmhmed mentioned this pull request Sep 7, 2024
Open
This was referenced Sep 7, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Sep 24, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 24, 2024
Closed
This was referenced Sep 24, 2024
Open
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 24, 2024
Merged
This was referenced Sep 25, 2024
Closed
Closed
Closed
@ananichoumchoum ananichoumchoum mentioned this pull request Sep 27, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 28, 2024
Closed
@yingbull yingbull mentioned this pull request Sep 28, 2024
Closed
@manh20012000 manh20012000 mentioned this pull request Sep 29, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@manh20012000 manh20012000 mentioned this pull request Oct 1, 2024
Open
This was referenced Oct 1, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 3, 2024
Closed
Closed
This was referenced Oct 4, 2024
Closed
Closed
This was referenced Oct 5, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Oct 25, 2024
Open
@0xk4b1r 0xk4b1r mentioned this pull request Oct 28, 2024
Closed
@yingbull yingbull mentioned this pull request Oct 28, 2024
Closed
@phucle1010 phucle1010 mentioned this pull request Nov 1, 2024
Open
@Abyss0108 Abyss0108 mentioned this pull request Nov 3, 2024
Open
@0xk4b1r 0xk4b1r mentioned this pull request Nov 4, 2024
Closed
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Nov 5, 2024
Open
@edwardsph edwardsph mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szydlovsky szydlovsky szydlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@latekvo @szydlovsky