Skip zero delay #6398
Merged
Skip zero delay #6398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
reviewed
Aug 12, 2024
apps/common-app/src/examples/RuntimeTests/tests/animations/withDelay/addDelays.test.tsx
Outdated
Show resolved
Hide resolved
piaskowyk
approved these changes
Aug 23, 2024
apps/common-app/src/examples/RuntimeTests/tests/animations/withDelay/addDelays.test.tsx
Outdated
Show resolved
Hide resolved
tjzel
pushed a commit
that referenced
this pull request
Aug 28, 2024
## Summary Closes #6341 Probably we want to fix the comparison inside `withDelay` to start the delayed animation as soon as the conditions are fulfilled, instead of waiting an additional frame. ```diff -if (now - startTime > delayMs || animation.reduceMotion) { +if (now - startTime >= delayMs || animation.reduceMotion) { ``` With this fix the delay of 0ms is only visible if you are really picky: <table> <tr> <td> BEFORE </td> <td> AFTER </td> </tr> <tr> <td> https://github.com/user-attachments/assets/261d92d2-f302-4240-96c8-3d14352431c2 </td> <td> https://github.com/user-attachments/assets/cf833359-7440-41d1-ab0a-daa3050bae15 </td> </tr> ### Test plan Includes simplification of tests of withDelay. Tested on both IOS and Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6341
Probably we want to fix the comparison inside
withDelayto start the delayed animation as soon as the conditions are fulfilled, instead of waiting an additional frame.With this fix the delay of 0ms is only visible if you are really picky:
Test plan
Includes simplification of tests of withDelay. Tested on both IOS and Android
Screen.Recording.2024-07-29.at.12.22.55.mov
Screen.Recording.2024-08-09.at.13.03.32.mov