Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getViewProp on Android, RN.74 #6441

Merged
merged 12 commits into from
Sep 23, 2024
Merged

Fix getViewProp on Android, RN.74 #6441

merged 12 commits into from
Sep 23, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Aug 22, 2024

Summary

We can't import CSSBackgroundDrawable on Reanimated lower than 75, so I had to change the affected code not to require it.

Test plan

@Latropos Latropos marked this pull request as ready for review August 22, 2024 14:58
@Latropos Latropos requested a review from piaskowyk August 22, 2024 14:58
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getViewProps changes appear good, but why do we need to update the ESLint plugin in the same PR? 🤔 Should we revert the plugin changes from this PR?

@Latropos Latropos requested a review from piaskowyk September 23, 2024 10:29
@Latropos Latropos added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 4e94ab6 Sep 23, 2024
10 checks passed
@Latropos Latropos deleted the acynk/fix-for-rn74 branch September 23, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants