Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Rewrite Shared Element Transition page #6455

Merged
merged 11 commits into from
Sep 16, 2024
Merged

docs: Rewrite Shared Element Transition page #6455

merged 11 commits into from
Sep 16, 2024

Conversation

patrycjakalinska
Copy link
Contributor

@patrycjakalinska patrycjakalinska commented Aug 28, 2024 •
edited
Loading

We've rewrite Shared Element Transition page.

  • Video examples
Screen.Recording.2024-09-12.at.11.18.13.mov

@patrycjakalinska patrycjakalinska force-pushed the @patrycjakalinska/shared-element-transition-rewrite branch from 9888b68 to 8dd8b90 Compare September 12, 2024 09:09
@patrycjakalinska patrycjakalinska marked this pull request as ready for review September 12, 2024 09:46
szydlovsky
szydlovsky requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's alright, some small adjustments needed

packages/docs-reanimated/docs/shared-element-transitions/overview.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/shared-element-transitions/overview.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/shared-element-transitions/overview.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/shared-element-transitions/overview.mdx Outdated Show resolved Hide resolved
szydlovsky
szydlovsky approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipit

piaskowyk
piaskowyk approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@patrycjakalinska patrycjakalinska force-pushed the @patrycjakalinska/shared-element-transition-rewrite branch from ff48d05 to eb26f7c Compare September 16, 2024 06:07
@patrycjakalinska patrycjakalinska added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 760d525 Sep 16, 2024
8 checks passed
@patrycjakalinska patrycjakalinska deleted the @patrycjakalinska/shared-element-transition-rewrite branch September 16, 2024 06:14
This was referenced Nov 8, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szydlovsky szydlovsky szydlovsky approved these changes

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrycjakalinska @piaskowyk @szydlovsky