Fix wrong exiting animation indices [New Architecture] #6526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomiejbloniarz
deleted the
@bartlomiejbloniarz/fix-layout-animation-bugs-2
branch
bartlomiejbloniarz
added a commit
that referenced
this pull request
Sep 20, 2024
## Summary
When an exiting animation is finished, we mark some views for removal.
Then we trigger `pullTransaction` to apply those removals. However, it
might happen that RN also tries to perform some transaction at the same
time. In the algorithm responsible for triggering exiting animations, if
we encounter a view marked for removal, we handle it right there by
calling `endAnimationsRecursively`. However, we also have to add this
view to the `toBeRemoved` list. Otherwise its neighbors will have
incorrect indices, and when one of them is removed the app will crash.
## Test plan
Test `[LA] View Flattening` example with:
```js
useEffect(() => {
setInterval(() => {
setVisible((prev) => !prev);
}, 0);
}, []);
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When an exiting animation is finished, we mark some views for removal. Then we trigger
pullTransactionto apply those removals. However, it might happen that RN also tries to perform some transaction at the same time. In the algorithm responsible for triggering exiting animations, if we encounter a view marked for removal, we handle it right there by callingendAnimationsRecursively. However, we also have to add this view to thetoBeRemovedlist. Otherwise its neighbors will have incorrect indices, and when one of them is removed the app will crash.Test plan
Test
[LA] View Flatteningexample with: