fix: Restore backwards C++ compatibility for NDK23 #6553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
added
the
Check compatibility
|
Hi, the c++ version value is wrong - it's not |
|
god damnit |
|
I just proposed a fix for the value: #6590 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary <!-- Explain the motivation for this PR. Include "Fixes #<number>" if applicable. --> There was a small typo in #6553 which caused building with c++17 to still fail. ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. --> Build works again with RN 0.72 which uses c++17. ## Notes - Fixes #6512 (comment) - Fixes #6584
tjzel
pushed a commit
that referenced
this pull request
Oct 11, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary <!-- Explain the motivation for this PR. Include "Fixes #<number>" if applicable. --> There was a small typo in #6553 which caused building with c++17 to still fail. ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. --> Build works again with RN 0.72 which uses c++17. ## Notes - Fixes #6512 (comment) - Fixes #6584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turns out preliminary support for NDK27 in
thiscaptures in lambdas for NDK 27 #6495broke support for NDK23. This PR brings back support for NDK23 which is used in React Native 0.72.
Test plan
Notes
Fixes
react-native-reanimated3.15.2 (RN 0.72.15, NDK 23) #6512