Add HostFunction
handling to _scheduleOnJS
#6571
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when a Host Function is called through
runOnJS
the app crashes, since we are only handling Remote Function in the_scheduleOnJS
method. For example the following code leads to a crash:This example works fine on the old architecture, because Timer functions are polyfilled there. On the New Architecture they are Host Functions, so we need to handle them separately.
Test plan
Check