Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Side effects paths in package.json #6634

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

MatiPl01
Copy link
Member

Summary

This PR adds missing initializers path to side effects (because some global variables are written in this file). It also fixes paths to remaining files (as there is no longer reanimated2 directory).

@MatiPl01 MatiPl01 self-assigned this Oct 25, 2024
@MatiPl01 MatiPl01 requested review from tjzel and tomekzaw October 25, 2024 11:25
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatiPl01 MatiPl01 enabled auto-merge October 25, 2024 18:27
@MatiPl01 MatiPl01 added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 4c12f43 Oct 25, 2024
10 checks passed
@MatiPl01 MatiPl01 deleted the @matipl01/fix-side-effects-paths branch October 25, 2024 18:36
tjzel pushed a commit that referenced this pull request Nov 25, 2024
## Summary

This PR adds missing initializers path to side effects (because some
global variables are written in this file). It also fixes paths to
remaining files (as there is no longer `reanimated2` directory).
@tjzel tjzel mentioned this pull request Nov 25, 2024
tjzel pushed a commit that referenced this pull request Nov 26, 2024
## Summary

This PR adds missing initializers path to side effects (because some
global variables are written in this file). It also fixes paths to
remaining files (as there is no longer `reanimated2` directory).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants