-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: touch event canceled with gesture disabled #1032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left some comments, please answer them and I think we can merge it then.
TestsExample/src/Test1032.tsx
Outdated
</NavigationContainer > | ||
<View> | ||
<Text>Gesture enabled</Text> | ||
<Switch value={gestureEnabled} onValueChange={setGestureEnable} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can switch gestureEnabled
directly in Second
by adding such switch there and using navigation.setOptions
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that being able to change it on both screens is useful, so I would keep it outside
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
Description
Fixes #1022
Changes
Adds event cancelation only when gesture should be recognized.
Test code and steps to reproduce
Test1032.tsx
Checklist