fix: touch event canceled with gesture disabled #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
approved these changes
Aug 2, 2021
TestsExample/src/Test1032.tsx
Outdated
| </NavigationContainer > | ||
| <View> | ||
| <Text>Gesture enabled</Text> | ||
| <Switch value={gestureEnabled} onValueChange={setGestureEnable} /> |
There was a problem hiding this comment.
You can switch gestureEnabled directly in Second by adding such switch there and using navigation.setOptions.
There was a problem hiding this comment.
I think that being able to change it on both screens is useful, so I would keep it outside
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1022
Changes
Adds event cancelation only when gesture should be recognized.
Test code and steps to reproduce
Test1032.tsx
Checklist