Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: format Example project on commit #1038

Merged
merged 15 commits into from
Aug 17, 2021
Merged

feat: format Example project on commit #1038

merged 15 commits into from
Aug 17, 2021

Conversation

kacperkapusciak
Copy link
Member

@kacperkapusciak kacperkapusciak commented Aug 4, 2021 •
edited
Loading

Description

This PR unifies code styling between an Example project and the library. Also, it connects the formatting of the Example project to the precommit hook.

Changes

  • Reformatted Example project code
  • Changed parameters of scripts in package.json to format Example/ directory
  • Changed Example/.prettierrc.json to match library configuration
  • Updated husky and lint-staged packages
  • Unified naming of the formatting and linting scripts

Checklist

  • Ensured that CI passes

@kacperkapusciak kacperkapusciak changed the title feat: format and lint Example project on commit feat: format Example project on commit Aug 17, 2021
Ubax
Ubax approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@Ubax Ubax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job 👍

@kacperkapusciak kacperkapusciak merged commit 48bb9ac into master Aug 17, 2021
@kacperkapusciak kacperkapusciak deleted the @kacperkapusciak/format-example-on-commit branch August 17, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ubax Ubax Ubax approved these changes

@WoLewicki WoLewicki Awaiting requested review from WoLewicki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kacperkapusciak @Ubax