Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds build checks #1055

Merged
merged 17 commits into from
Aug 18, 2021
Merged

chore: Adds build checks #1055

merged 17 commits into from
Aug 18, 2021

Conversation

Ubax
Copy link
Contributor

@Ubax Ubax commented Aug 17, 2021

Description

Adds build checks for iOS, tvOS and android.

Test code and steps to reproduce

Checks should pass in this PR.
They should fail in #1056.

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

@Ubax Ubax changed the title chore: Adds github actions for build checks chore: Adds build checks Aug 17, 2021
@WoLewicki WoLewicki mentioned this pull request Aug 17, 2021
2 tasks
@Ubax Ubax requested a review from WoLewicki August 17, 2021 11:32
Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎉 Left some small nit-picks to fix 😃

.github/workflows/android-build-test.yml Outdated Show resolved Hide resolved
node-version: 14
cache: 'yarn'
- name: Install dependencies
run: yarn && cd TestsExample && yarn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is yarn run only here in the main dir of react-native-screens and omitted in other builds? Are we certain that this job will run first and packages will be cached for others? It so I'd still split it to separate steps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was there because before I was also running emulator and the app crashed without root dependencies.
I decided that it is not necessary to run it (without emulator job takes 3 minutes instead of 5 and can be ran on ubuntu).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the unnecessary yarn

.github/workflows/tv-os-build-test.yml Outdated Show resolved Hide resolved
.github/workflows/android-build-test.yml Outdated Show resolved Hide resolved
@Ubax Ubax merged commit ce36e0b into master Aug 18, 2021
@Ubax Ubax deleted the @ubax/add-build-checks-2 branch August 18, 2021 10:34
@henninghall
Copy link
Contributor

Nice one! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants