chore: Adds build checks #1055
Merged
chore: Adds build checks #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubax
changed the title
WoLewicki
reviewed
Aug 17, 2021
added 9 commits
August 18, 2021 08:20
kacperkapusciak
requested changes
Aug 18, 2021
| node-version: 14 | ||
| cache: 'yarn' | ||
| - name: Install dependencies | ||
| run: yarn && cd TestsExample && yarn |
There was a problem hiding this comment.
Why is yarn run only here in the main dir of react-native-screens and omitted in other builds? Are we certain that this job will run first and packages will be cached for others? It so I'd still split it to separate steps.
There was a problem hiding this comment.
It was there because before I was also running emulator and the app crashed without root dependencies.
I decided that it is not necessary to run it (without emulator job takes 3 minutes instead of 5 and can be ran on ubuntu).
There was a problem hiding this comment.
I removed the unnecessary yarn
kacperkapusciak
approved these changes
Aug 18, 2021
|
Nice one! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds build checks for iOS, tvOS and android.
Test code and steps to reproduce
Checks should pass in this PR.
They should fail in #1056.
Checklist