Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option for custom swipe animation #1084

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

WoLewicki
Copy link
Member

@WoLewicki WoLewicki commented Aug 25, 2021

Description

PR adding customAnimationOnSwipe used for providing animation from stackAnimation when swiping the screen on iOS.

This PR changes the behavior of simple_push since now it needs customAnimationOnSwipe to be set to true in order to use its back animation

Checklist

ios/RNSScreen.m Outdated
@@ -722,6 +722,7 @@ @implementation RNSScreenManager
RCT_EXPORT_VIEW_PROPERTY(onDisappear, RCTDirectEventBlock);
RCT_EXPORT_VIEW_PROPERTY(onDismissed, RCTDirectEventBlock);
RCT_EXPORT_VIEW_PROPERTY(onTransitionProgress, RCTDirectEventBlock);
RCT_EXPORT_VIEW_PROPERTY(customAnimatonOnSwipe, BOOL);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo Animaton -> Animation everywhere in this PR 😄

Suggested change
RCT_EXPORT_VIEW_PROPERTY(customAnimatonOnSwipe, BOOL);
RCT_EXPORT_VIEW_PROPERTY(customAnimationOnSwipe, BOOL);

@WoLewicki WoLewicki merged commit 76ebb12 into master Aug 26, 2021
@WoLewicki WoLewicki deleted the @wolewicki/ios-custom-animation-on-swipe branch August 26, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants