Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make search bar appear on iOS 12 #1115

Merged
merged 1 commit into from
Sep 8, 2021
Merged

fix: make search bar appear on iOS 12 #1115

merged 1 commit into from
Sep 8, 2021

Conversation

WoLewicki
Copy link
Member

Description

For some reason when searchBar's controller is instantiated with new, the searchBar itself does not appear on iOS 12. Changing it to [[UISearchController alloc] initWithSearchResultsController:nil] resolves the issue.

Test code and steps to reproduce

Test758.tsx with iOS 12.

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

@WoLewicki WoLewicki merged commit aca5d4c into master Sep 8, 2021
@WoLewicki WoLewicki deleted the @wolewicki/fix-ios-12-search-bar branch September 8, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kacperkapusciak kacperkapusciak kacperkapusciak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WoLewicki @kacperkapusciak