remove com.diffplug.spotless version from build.gradle

[cruzach]

Description

Fixes android builds failing with

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/charliecruzan/source/expo/node_modules/react-native-screens/android/build.gradle' line: 14

* What went wrong:
Error resolving plugin [id: 'com.diffplug.spotless', version: '5.14.1']
> Plugin request for plugin already on the classpath must not include a version

If projects installing react-native-screens also use com.diffplug.spotless

Changes

removed the version specification from build.gradle, and placed it in settings.gradle inside of pluginManagement block, as suggested here

Test code and steps to reproduce

init a RN project, add

plugins {
  id "com.diffplug.spotless" version "5.14.1"
}

to build.gradle

yarn add react-native-screens, and try to build.

Checklist

• Included code example that can be used to test this change
• Updated TS types
• Updated documentation:
  • https://github.com/software-mansion/react-native-screens/blob/master/guides/GUIDE_FOR_LIBRARY_AUTHORS.md
  • https://github.com/software-mansion/react-native-screens/blob/master/native-stack/README.md
  • https://github.com/software-mansion/react-native-screens/blob/master/createNativeStackNavigator/README.md
  • https://github.com/software-mansion/react-native-screens/blob/master/src/types.tsx
  • https://github.com/software-mansion/react-native-screens/blob/master/src/native-stack/types.tsx
• Ensured that CI passes

[kacperkapusciak]

This change would require all of the developers who use react-native-screens to install spotless in their project - hence the CI fail here and in the expo repo. I'm also trying to fix this issue.

Cheers