Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: missing Screen prop: swipeDirection #1461

Merged
merged 8 commits into from
Jun 1, 2022
Merged

feat: missing Screen prop: swipeDirection #1461

merged 8 commits into from
Jun 1, 2022

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Jun 1, 2022 •
edited
Loading

Description

Added support for swipeDirection (iOS only) prop on Fabric

Changes

  • added it to SceenNativeComponent.js (for codegen)
  • added prop update inside RNSScreenView#updateProps:oldProps:
  • added noop for Android
  • copied newly generated interfaces to paper directory

Test code and steps to reproduce

  • Test1260 in FabricTestExample

Checklist

@kkafar kkafar marked this pull request as ready for review June 1, 2022 10:10
@kkafar kkafar requested a review from WoLewicki June 1, 2022 10:58
WoLewicki
WoLewicki approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@kkafar kkafar merged commit 54419b9 into main Jun 1, 2022
@kkafar kkafar deleted the @kkafar/missing-prop-swipeDirection branch June 1, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoLewicki WoLewicki WoLewicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkafar @WoLewicki