Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dependency on react-navigation@v4 & unify test example apps #1492

Merged
merged 5 commits into from
Jun 28, 2022

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Jun 27, 2022

Description

I removed dependency on react-navigation@v4 in TestsExample & copied tests from TestsExample to FabricTestsExample (all tests should work now, as support for reanimated was added here; maybe except FullWindowOverlay - WIP, PR will come soon)

Changes

  • Removed react-navigation & react-navigation-stack dependency from TestsExample/package.json & ran yarn install
  • Copied already not present tests to FabricTestsExample
  • Removed Test765 as it depended on react-navigation@v4

Test code and steps to reproduce

Open FabricTestExample app

Checklist

@kkafar kkafar force-pushed the @kkafar/cleanup-test-examples branch from 0886a8c to e7d9d7e Compare June 27, 2022 14:56
@kkafar kkafar changed the title chore: add missing import in App.js chore: remove dependency on react-navigation@v4 & unify test example apps Jun 27, 2022
@kkafar kkafar requested a review from WoLewicki June 27, 2022 15:57
@kkafar kkafar marked this pull request as ready for review June 27, 2022 15:57
@kkafar kkafar merged commit 318e613 into main Jun 28, 2022
@kkafar kkafar deleted the @kkafar/cleanup-test-examples branch June 28, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants