-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add FullWindowOverlay
component for Fabric
#1495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
force-pushed
the
@kkafar/fabric-full-window-overlay
branch
from
June 28, 2022 13:09
30269fc
to
e8f6163
Compare
WoLewicki
reviewed
Jun 28, 2022
However more extensive logic may be required for Fabric as it seems to me, that _container wont be initialized for the second time
kkafar
force-pushed
the
@kkafar/fabric-full-window-overlay
branch
from
June 29, 2022 08:48
7ab9905
to
1c5c4d9
Compare
When the component unmounts we remove it from window's children, so when the component gets recycled we need to add it back. Also see comments added in the code.
WoLewicki
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
FullWindowOverlay
component support for Fabric.Changes
init
method & extracted common initialisation code to separate method.RCTTouchHandler
->RCTSurfaceTouchHandler
)Test code and steps to reproduce
Test1096
inFabricTestExample
Checklist