Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop React Native 0.62, 0.63 since 3.14.0 #1533

Merged
merged 4 commits into from
Jul 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ Screens are already integrated with the React Native's most popular navigation l

| version | react-native version |
| ------- | -------------------- |
| 3.14.0+ | 0.64.0+ |
| 3.0.0+ | 0.62.0+ |
| 2.0.0+ | 0.60.0+ |

Expand Down
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ android {
}

defaultConfig {
minSdkVersion safeExtGet('minSdkVersion', 16)
minSdkVersion safeExtGet('minSdkVersion', 21)
targetSdkVersion safeExtGet('targetSdkVersion', 22)
versionCode 1
versionName "1.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,15 +130,14 @@ class ScreenStackHeaderConfig(context: Context) : ViewGroup(context) {
return null
}

@SuppressLint("ObsoleteSdkInt") // to be removed when support for < 0.64 is dropped
fun onUpdate() {
val stack = screenStack
val isTop = stack == null || stack.topScreen == parent
if (!mIsAttachedToWindow || !isTop || mDestroyed) {
return
}
val activity = screenFragment?.activity as AppCompatActivity? ?: return
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1 && mDirection != null) {
if (mDirection != null) {
if (mDirection == "rtl") {
toolbar.layoutDirection = LAYOUT_DIRECTION_RTL
} else if (mDirection == "ltr") {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ object ScreenWindowTraits {

@SuppressLint("ObsoleteSdkInt") // to be removed when support for < 0.64 is dropped
internal fun setColor(screen: Screen, activity: Activity?, context: ReactContext?) {
if (activity == null || context == null || Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) {
if (activity == null || context == null) {
return
}
if (mDefaultStatusBarColor == null) {
Expand Down