fix: add react-native.config.js to npm package
#1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kkafar
added a commit
that referenced
this pull request
Oct 12, 2022
## Description Fixes #1614 #1611 added `react-native.config.js` file to the library which uses features supported since `@react-native-cli@9.0.0` thus causing library fail to link while on Paper with React Native < 0.70. This fix is borrowed from `react-native-safe-area-context`. ## Changes Added check for `@react-native-community/cli-platform-android` version in `react-native.config.js`. ## Test code and steps to reproduce -- ## Checklist - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Autolinking was added with #1585 and it added
react-native.config.jsfile with codegen configuration, but it did not add this file to npm include list causing its absence in final released package...Fixes #1608
Changes
Added
react-native.config.jsto npm file list in mainpackage.jsonTest code and steps to reproduce
See #1608 for reproductions.
Checklist