Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FabricTestExample fails to start due to new react-native.config.js #1624

Merged
merged 2 commits into from
Oct 24, 2022
Merged

fix: FabricTestExample fails to start due to new react-native.config.js #1624

merged 2 commits into from
Oct 24, 2022

Commits on Oct 14, 2022

  1. style: add missing comas in metro.config.js

    @kkafar
    kkafar committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    db493e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. chore: use "resolutions" field to fix check in react-native.config.js 

    Added library dev dependency on:

"@react-native-community/cli-platform-android": "^9.0.0",
"@react-native-community/cli": "^9.0.0",
"@react-native-community/cli-platform-ios": "^9.0.0"

and added these packages to yarn `resolutions` field in library's
`package.json`. This causes the check in `react-native.config.js` to be
resolved correctly, despite still being taken from library's
`node_modules`.
    @kkafar
    kkafar committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    4422ee9 View commit details
    Browse the repository at this point in the history