fix: android screen stack animation

[janicduplessis]

Description

There was some issues with android animation, the root cause is the drawing order, not the actual animations. This reverts the changes to the animations so it matches stock android ones and always reverse drawing order for android api 33+.

Changes

Revert the animation changes in 00543fb and 05f4dd7.

Return true from needsDrawReordering when api 33+.

Screenshots / GIFs

Here you can add screenshots / GIFs documenting your change.

You can add before / after section if you're changing some behavior.

Before

Api 33

Screen.Recording.2024-01-24.at.12.28.26.mov

The mitigations for wrong drawing order makes it kind of hard to see the issue, but going frame by frame we can see the animation is weird initially

After

Api 31

Screen.Recording.2024-01-24.at.12.19.03.mov

Api 33

Screen.Recording.2024-01-24.at.12.25.04.mov

We can now see that the new screen is actually drawn on top of the old one so it looks better during the initial fade.

Test code and steps to reproduce

Tested in example app

Checklist

• Included code example that can be used to test this change
• Updated TS types
• Updated documentation:
  • https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md
  • https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md
  • https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx
  • https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx
• Ensured that CI passes

[janicduplessis]

cc @kkafar

[janicduplessis]

Looks like CI failures are unrelated?

[kkafar]

Yeah, they most likely are aren't. Once I check out the behaviour we will proceed with merging.
Thanks for contribution 🙌🏻

[tboba]

Hi @janicduplessis, @kkafar - the issue with CI is not related to this PR. Looks like changes made in #1913 have broke our CI (I've already discovered that on screens without goBackGesture, back button on Android always acts like pressing and holding while tapping it). So I wouldn't worry about the CI, I've already reported to @piaskowyk about this problem and waiting for his response 👀

[tboba]

@janicduplessis That looks soooo damn way better! 🤩
I think the biggest advantage of this change is that white remaining white fields are no more (pictured below).

Screen.Recording.2024-02-13.at.13.54.28.mov

I've also fixed API 28 and it works fine. Thanks!

[tboba]

Just one comment from me. Also, could you merge changes from main, so that the CI build will be fixed?

[tboba]

Can you add a comment here why we're comparing Android version? (just for a context, that since API 33 the default animation has changed and because of the "sliding" we need to draw reordering 👍)

[janicduplessis]

@tboba Done!

[tboba]

Love it, thanks @janicduplessis!
If we're not in a hurry, I'll confirm from the other commenters from this PR that the issues with the animation are not the case from them. Is that alright?

[janicduplessis]

Sounds good.

[efstathiosntonas]

@janicduplessis thank you for this, can you please run some tests in foldable devices like the one in the screenshot?

I see some weird jumpiness on my end

[tboba]

Hi @efstathiosntonas, I've just tested this animation with provided emulator configuration and I can't see any jumpiness there 🤔 Maybe you've got some other emulator enabled that stutters your foldable device?
For now I'll merge this PR, but we need to observe if there's any issues, related to the animation there.

[tboba]

🚀🚀