fix: change default gesture from Tap to Fling, fix failing CI #2023
Conversation
tboba
changed the title
Co-authored-by: m-bert <michal.bert@swmansion.com>
| @@ -8,7 +8,7 @@ describe('Events', () => { | |||
| await waitFor(element(by.id('root-screen-playground-Events'))) | |||
| .toBeVisible() | |||
| .whileElement(by.id('root-screen-examples-scrollview')) | |||
| .scroll(200, 'down'); | |||
| .scroll(100, 'down', NaN, 0.85); | |||
There was a problem hiding this comment.
What is the reason for changing this value?
There was a problem hiding this comment.
I see that on higher Android APIs with gestures as a device navigation, phone can accidentally go into the preview of apps in the background - that's why I've added the offset here
|
Also, I am not sure I understand what is going on exactly. Why does gesture-handler call the |
|
@WoLewicki we're not testing them, but this change does not only limit to the case of the CI. Because of the default |
|
Ok keep me updated 🚀 |
…re-mansion#2023) ## Description Unfortunately, the `Tap` gesture as the default gesture in ScreenGestureDetector breaks the back button on Android and iOS. Somehow, gesture detector while "tapping" just taps and holds the back button, resulting in breaking CI and our testing apps. This PR changes this gesture to `Fling`, resulting in correct behavior. It cannot be changed to `Manual` gesture, since it also breaks the iOS CI. ## Changes - Changed gesture from Tap to Fling - Updated detox from 20.11.4 to 20.17.0 - Fixed Android E2E tests by building the bundle with .so files on x86_64 architecture - Changed scroll action that was opening background apps preview on Android 33 (and higher) levels - Adjusted CI parameters, fixed the typo of artifact names ## Test code and steps to reproduce You can go through Example app and try to click back button in `Events`. Right now it should work properly. ## Checklist - [x] Ensured that CI passes --------- Co-authored-by: m-bert <michal.bert@swmansion.com>
Description
Unfortunately, the
Tapgesture as the default gesture in ScreenGestureDetector breaks the back button on Android and iOS. Somehow, gesture detector while "tapping" just taps and holds the back button, resulting in breaking CI and our testing apps.This PR changes this gesture to
Fling, resulting in correct behavior. It cannot be changed toManualgesture, since it also breaks the iOS CI.Changes
Test code and steps to reproduce
You can go through Example app and try to click back button in
Events. Right now it should work properly.Checklist