feat: Migrate example apps to use react-navigation #2084
Conversation
|
Hi @tboba Just seen that it looks like you struggle with CI/e2e tests (timeout 120000ms) - I think I experience the same problem, but I haven't found a solution yet 🙈 I've tried many things:
And all that didn't help 😔 If you find a fix - please let me know what exactly helped you 😅 From my observations- it looks like GH runners became very slow. I've captured videos and when I see them - app works veeeryyy slow 🤷♂️ So now I tend to think that something happened to GH hardware (but maybe a new version of software has been released somewhere and we use it now and it causes a slowness). Anyway just wanted to share my observations here - maybe you'll find them useful 😅 |
|
@kirillzyusko Oh, yeaaaah It took me soo long today to observe what have I changed in my files, so that our emulators are struggling with running 😅 Something's definitely broken on GH infrastructure 😕 Thanks for letting me know! |
tboba
changed the title
…2084) ## Description This PR migrates our example apps to use react-navigation. Because we're right now using react-navigation as a submodule (and we intent to remove native-stack v5 from codebase), it's mandatory to migrate all of the example apps to @react-navigation/native-stack. To do this, I've moved all imports for creating navigator to use native-stack v6 and changed the naming of the props. Right now all of the examples should work, but it's important to build `lib` directories from submodule (using `yarn build`) beforehand. ## Changes - Moved all navigators to use `@react-navigation/native-stack` - Changed naming of the props to match native-stack v6 - Changed E2E tests a little ## Test code and steps to reproduce You can just run example apps to test this change. ## Checklist - [x] Ensured that CI passes
## Description This PR is a follow-up to software-mansion#2084 that fixes setting incorrect RTL mode in our example apps. The reason why it is being forced is that `I18nManager.forceRTL(true)` is being called from the global scope, which causes to force RTL, even if we're only importing the component **from file**. ## Changes - Moved `I18nManager.forceRTL(true);` to inner scope of App components. ## Test code and steps to reproduce Just run TestsExample & FabricTestExample ¯\_(ツ)_/¯ ## Checklist - [X] Ensured that CI passes
Description
This PR migrates our example apps to use react-navigation. Because we're right now using react-navigation as a submodule (and we intent to remove native-stack v5 from codebase), it's mandatory to migrate all of the example apps to @react-navigation/native-stack. To do this, I've moved all imports for creating navigator to use native-stack v6 and changed the naming of the props. Right now all of the examples should work, but it's important to build
libdirectories from submodule (usingyarn build) beforehand.Changes
@react-navigation/native-stackTest code and steps to reproduce
You can just run example apps to test this change.
Checklist