Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Android): prevent throwing exception with UnsatisfiedLinkError #2128

Merged
merged 1 commit into from
May 13, 2024
Merged

fix(Android): prevent throwing exception with UnsatisfiedLinkError #2128

merged 1 commit into from
May 13, 2024

Conversation

piaskowyk
Copy link
Member

Description

Fixes #2115

The System.loadLibrary("rnscreens") can throw an exception that inherits from the Error class instead of the Exception class.

@piaskowyk piaskowyk requested a review from kkafar May 10, 2024 18:55
kkafar
kkafar reviewed May 11, 2024
View reviewed changes
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

My only worry is whether this is only type of exception that can be thrown here. Maybe going with more generic error type could be worth considering

@piaskowyk
Copy link
Member Author

According to the Android documentation in our case only UnsatisfiedLinkError exception can be thrown.

kkafar
kkafar approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This convinces me

@piaskowyk piaskowyk merged commit 9d31514 into main May 13, 2024
4 checks passed
@piaskowyk piaskowyk deleted the @piaskowyk/catch-UnsatisfiedLinkError branch May 13, 2024 07:33
@tboba tboba changed the title Catch UnsatisfiedLinkError fix(Android): prevent throwing exception with UnsatisfiedLinkError May 13, 2024
@toomeem toomeem mentioned this pull request Jul 10, 2024
Merged
@2lambda123 2lambda123 mentioned this pull request Jul 11, 2024
Merged
This was referenced Jul 17, 2024
Open
Open
Open
Open
Open
@asraful-cse asraful-cse mentioned this pull request Jul 21, 2024
Open
@ImNotVarun ImNotVarun mentioned this pull request Jul 22, 2024
Open
This was referenced Jul 22, 2024
Open
Open
Open
This was referenced Jul 24, 2024
Open
Open
This was referenced Jul 25, 2024
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-io snyk-io bot mentioned this pull request Aug 12, 2024
Open
This was referenced Aug 20, 2024
Open
Open
@WesleyR10 WesleyR10 mentioned this pull request Aug 21, 2024
Open
@shonore shonore mentioned this pull request Aug 22, 2024
Open
@2lambda123 2lambda123 mentioned this pull request Aug 22, 2024
Merged
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Closed
This was referenced Aug 23, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Aug 30, 2024
Open
Open
Open
Open
Open
@undrthegraveyard undrthegraveyard mentioned this pull request Sep 4, 2024
Closed
@asraful-cse asraful-cse mentioned this pull request Sep 6, 2024
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
@Ayush-Bulbule Ayush-Bulbule mentioned this pull request Oct 2, 2024
Merged
@tobistudio tobistudio mentioned this pull request Oct 3, 2024
Open
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
@piaskowyk @ja1ns
Catch UnsatisfiedLinkError (software-mansion#2128)
fc27e89 
## Description

Fixes
software-mansion#2115

The `System.loadLibrary("rnscreens")` can throw an exception that
inherits from the `Error` class instead of the `Exception` class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkafar kkafar kkafar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@piaskowyk @kkafar