Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TVOS): rebuild TVOSExample app with RN 0.74.1 #2155

Merged
merged 18 commits into from
Jun 10, 2024

Conversation

alduzy
Copy link
Member

@alduzy alduzy commented May 22, 2024

Description

PR rebuilding TVOSExample from scratch with RN 0.74.1.

Changes

  • rebuild TVOSExample app with latest RN version

Test code and steps to reproduce

Checklist

@alduzy alduzy requested review from tboba and WoLewicki May 22, 2024 12:55
@alduzy alduzy requested a review from kkafar May 22, 2024 14:34
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to make CI work before we proceed here. It does somehow build on main, wo we should be able to make it work here too (as well as running it locally).

@alduzy alduzy requested a review from kkafar May 28, 2024 13:52
Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🥳

.github/workflows/tv-os-build-test.yml Outdated Show resolved Hide resolved
.github/workflows/tv-os-build-test.yml Show resolved Hide resolved
TVOSExample/.watchmanconfig Show resolved Hide resolved
TVOSExample/android/app/build.gradle Show resolved Hide resolved
TVOSExample/ios/Podfile Show resolved Hide resolved
TVOSExample/src/BottomTabsExample.tsx Outdated Show resolved Hide resolved
@alduzy alduzy requested a review from tboba June 10, 2024 09:18
Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay then 👍

@alduzy alduzy merged commit e35da5a into main Jun 10, 2024
2 checks passed
@alduzy alduzy deleted the @alduzy/rebuild-tvosexample branch June 10, 2024 11:40
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
…#2155)

## Description

PR rebuilding TVOSExample from scratch with RN 0.74.1.

## Changes

- rebuild TVOSExample app with latest RN version

<!--

## Screenshots / GIFs

Here you can add screenshots / GIFs documenting your change.

You can add before / after section if you're changing some behavior.

### Before

### After

-->

## Test code and steps to reproduce

<!--
Please include code that can be used to test this change and short
description how this example should work.
This snippet should be as minimal as possible and ready to be pasted
into editor (don't exclude exports or remove "not important" parts of
reproduction example)
-->

## Checklist

- [ ] Included code example that can be used to test this change
- [ ] Updated TS types
- [ ] Updated documentation: <!-- For adding new props to native-stack
-->
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx
- [ ] Ensured that CI passes

---------

Co-authored-by: Tymoteusz Boba <Tymoteusz.Boba@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants