refact: example apps file structure and ts support #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alduzy
changed the title
alduzy
changed the title
kkafar
approved these changes
Jun 7, 2024
kkafar
reviewed
Jun 7, 2024
WoLewicki
reviewed
Jun 7, 2024
WoLewicki
approved these changes
Jun 7, 2024
|
I've triggered CI again as e2e Android tests & iOS build on Fabric have failed. |
|
The failing CI check |
maciekstosio
approved these changes
Jun 10, 2024
kkafar
approved these changes
Jun 11, 2024
tboba
reviewed
Jun 11, 2024
Comment on lines
-53
to
-58
| if (moduleName.startsWith('@react-navigation')) { | ||
| // For some reason, react-navigation packages don't want to resolve from | ||
| // the project's node_modules, so we need to use standard Metro resolver. | ||
| return context.resolveRequest(context, moduleName, platform); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why this has been removed? Were there any errors regarding resolving this module? I'm just curious 🤔
There was a problem hiding this comment.
After deleting the package.json file from apps/examples this code had to be deleted as the app couldn't find the react navigation packages
This was referenced Aug 20, 2024
This was referenced Aug 23, 2024
This was referenced Aug 30, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…2174) ## Description This PR intents to simplify example and test example apps file structure and fix typescript support. ## Changes - removed package.json inside common dir and adjusted metro config to work with those dependencies - relocated app.js file inside test examples common dir to match examples dir structure - added submodules paths to the root tsconfig and extended it in the example dirs <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce - Build and check wether the example and test example app works well on both paper and fabric architectures. - Have a look at the imports in any file inside apps/ directory and enjoy less red marks + full typescript support for linked packages! ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intents to simplify example and test example apps file structure and fix typescript support.
Changes
Test code and steps to reproduce
Checklist