-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iOS): white flash on tab change when using native stack #2188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started looking and have some initial question before we can proceed
26df1fa
to
2ba71d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've played around with the PR for 10 minutes & haven't found any broken behaviour.
Provided that you tested it thoroughly I believe we can proceed.
Thanks a lot!
Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving under the same conditions as above! Great job!
Tested it using the provided |
Let me do a quick final check on examples if this works and I guess we can proceed with this one! |
Why are we need to test scenario from |
Alright, I understand 👍 |
Did you test on all supported |
I've just tested the change on iOS 15.5 and cannot spot any issues there 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…-mansion#2188) ## Description This PR gets rid of undesired white flashes during `maybeAddToParentAndUpdateContainer`. The white flash was present on paper architecture when `unmountOnBlur` option was set to true on parent bottomStackNavigator (see repro). The affected logic was previously introduced or changed by following PRs: - software-mansion#600 - software-mansion#613 - software-mansion#643 The removed `_hasLayout` was initially added by software-mansion#600 in order to resolve an issue: software-mansion#432. However the logic was later changed by software-mansion#613 in order to fix another issue and the added `_hasLayout` may not fix anything eventually, as stated by [this comment](software-mansion#432 (comment)). Fixes software-mansion#1645. ## Changes - removed `_hasLayout` variable - added repros ## Screenshots / GIFs ### Before https://github.com/software-mansion/react-native-screens/assets/91994767/226a32d7-728b-48dd-b21a-6a1e4195add2 ### After https://github.com/software-mansion/react-native-screens/assets/91994767/32febcf1-d159-4a9d-ae3a-373042732a6d ## Test code and steps to reproduce - added `Test1645.js` repro to test examples - added `Test432.tsx` repro to test examples ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes --------- Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
Description
This PR gets rid of undesired white flashes during
maybeAddToParentAndUpdateContainer
. The white flash was present on paper architecture whenunmountOnBlur
option was set to true on parent bottomStackNavigator (see repro).The affected logic was previously introduced or changed by following PRs:
The removed
_hasLayout
was initially added by #600 in order to resolve an issue: #432.However the logic was later changed by #613 in order to fix another issue and the added
_hasLayout
may not fix anything eventually, as stated by this comment.Fixes #1645.
Changes
_hasLayout
variableScreenshots / GIFs
Before
Screen.Recording.2024-06-17.at.17.56.22.mov
After
Screen.Recording.2024-06-17.at.17.55.15.mov
Test code and steps to reproduce
Test1645.js
repro to test examplesTest432.tsx
repro to test examplesChecklist