-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Android): update spotless & ktlint #2189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes! Can we also put an update in this PR of distributionUrl
field in main gradle-wrapper.properties
file, so that we could bump gradle version here as well?
Will do it in separate PR |
besides that it is already bumped to 7.5.1 |
Yeah, I've seen that you've bumped it yesterday 😄 nevermind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through the code to make sure whether there are no semantics changes it all seems ok.
## Description Encountered some errors (seems they were looking for old CMake version (3.10.2)) & decided to bump these deps as they are long overdue. ## Changes Ktlint: 0.43 -> 1.1.1 spotless 6.11 -> 6.22 ## Checklist - [ ] Ensured that CI passes
## Description Encountered some errors (seems they were looking for old CMake version (3.10.2)) & decided to bump these deps as they are long overdue. ## Changes Ktlint: 0.43 -> 1.1.1 spotless 6.11 -> 6.22 ## Checklist - [ ] Ensured that CI passes
Description
Encountered some errors (seems they were looking for old CMake version (3.10.2)) & decided to bump these deps as they are long overdue.
Changes
Ktlint: 0.43 -> 1.1.1
spotless 6.11 -> 6.22
Checklist