fix(iOS, Fabric): add missing logic for finding touch handler #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
force-pushed
the
@kkafar/fix-touchable-on-paper
branch
from
abfc9fb
to
fef6798
Compare
kkafar
commented
Jun 18, 2024
Comment on lines
+10
to
+12
| #define RNS_TOUCH_HANDLER_ARCH_TYPE RCTSurfaceTouchHandler | ||
| #else | ||
| #define RNS_TOUCH_HANDLER_ARCH_TYPE RCTTouchHandler |
There was a problem hiding this comment.
I tried using typedefs instead of macros here, but stumbled upon issues with nullability (section about "audited regions") and had unexpected issues doing any casting for typedef'd types -> went for macros.
kkafar
changed the title
tboba
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
If we're keeping in this file only TouchHandler-specific code, I would call this file as UIView+RNSTouchHandlers.
There was a problem hiding this comment.
I used already existing category name - RNSUtility (we have already introduced this one), and I think it is better suited for future, as putting any more utility methods in RNSTouchHandlers wouldn't make sense. It's again the matter of taste... I'll keep current version, but thanks for suggestion!
| [touchHandler rnscreens_cancelTouches]; | ||
| } | ||
| #endif // RCT_NEW_ARCH_ENABLED | ||
| [[self rnscreens_findTouchHandlerInAncestorChain] rnscreens_cancelTouches]; |
There was a problem hiding this comment.
Can we do something like:
RNS_TOUCH_HANDLER_ARCH_TYPE *touchHandler = [self rnscreens_findTouchHandlerInAncestorChain];
[touchHandler rnscreens_cancelTouches];to improve readability?
There was a problem hiding this comment.
I find it quite opposite 😄 I'm mean the redundant variable strikes me => I'll stay by current version as this is taste related, but thanks.
alduzy
pushed a commit
that referenced
this pull request
Jun 28, 2024
## Description `- [RNSScreen touchHandler]` method was missing implementation for Fabric, adding it here. ## Changes - **Add category on UIView with code for touch handler finding** - **Use the new category to simplify implementation** ## Test code and steps to reproduce `Test2118` - tested on both archs & works just fine ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes
2 tasks
kkafar
added a commit
that referenced
this pull request
Jul 2, 2024
…sted stack (#2223) ## Description In #2193 I've made a mistake - on Paper, when there is no touch handler held in `_touchHandler` field I've started lookup for touch handler in ancestor chain from `self` -> which leads to infinite loop when swiping back in nested-stack navigation scenario. ## Changes * Started lookup from superview. ## Test code and steps to reproduce `Test2223` 1. Navigate to NestedStack. 2. Navigate to NestedStack details screen. 3. Use swipe gesture to go-back W/o this PR the application will crash hitting infinite loop. Also test that this behaviour remains fixed: * #2131 ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes
This was referenced Aug 23, 2024
This was referenced Aug 27, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…re-mansion#2193) ## Description `- [RNSScreen touchHandler]` method was missing implementation for Fabric, adding it here. ## Changes - **Add category on UIView with code for touch handler finding** - **Use the new category to simplify implementation** ## Test code and steps to reproduce `Test2118` - tested on both archs & works just fine ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…sted stack (software-mansion#2223) ## Description In software-mansion#2193 I've made a mistake - on Paper, when there is no touch handler held in `_touchHandler` field I've started lookup for touch handler in ancestor chain from `self` -> which leads to infinite loop when swiping back in nested-stack navigation scenario. ## Changes * Started lookup from superview. ## Test code and steps to reproduce `Test2223` 1. Navigate to NestedStack. 2. Navigate to NestedStack details screen. 3. Use swipe gesture to go-back W/o this PR the application will crash hitting infinite loop. Also test that this behaviour remains fixed: * software-mansion#2131 ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
- [RNSScreen touchHandler]method was missing implementation for Fabric, adding it here.Changes
Test code and steps to reproduce
Test2118- tested on both archs & works just fineChecklist