Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: moved android e2e to ubuntu #2196

Merged
merged 18 commits into from
Jun 21, 2024
Merged

chore: moved android e2e to ubuntu #2196

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b263064
chore: moved android e2e to ubuntu
alduzy Jun 19, 2024
8760c35
feat: added Enable KVM group perms step
alduzy Jun 19, 2024
85c80f2
feat: added free disk space step
alduzy Jun 19, 2024
981585a
fix: remove added cache step
alduzy Jun 19, 2024
8ff9958
fix: emulator runner version
alduzy Jun 19, 2024
05a9e44
changed api level
alduzy Jun 19, 2024
9807b8f
feat: added worklfow caching
alduzy Jun 19, 2024
da7c56d
fix: remove added yarn cache
alduzy Jun 19, 2024
bdae6ea
feat: revert gradle cache, changed tests target
alduzy Jun 19, 2024
b891686
fix: added Install AVD dependencies step
alduzy Jun 19, 2024
74ef98a
fix: changed target
alduzy Jun 19, 2024
d98dd2a
Merge remote-tracking branch 'origin/main' into @alduzy/move-android-…
alduzy Jun 21, 2024
7bb727d
removed extra AVD step
alduzy Jun 21, 2024
6d7bbd9
remove extra KVM step (try)
alduzy Jun 21, 2024
91f3433
fix: bring back KVM
alduzy Jun 21, 2024
8662f1f
chore: bump android api
alduzy Jun 21, 2024
8fb71a1
feat: added AVD cache
alduzy Jun 21, 2024
f864103
added install AVD dependencies step
alduzy Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 30 additions & 7 deletions .github/workflows/android-e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,30 @@ on:
workflow_dispatch:
jobs:
test:
runs-on: macos-12
runs-on: ubuntu-latest
timeout-minutes: 60
env:
WORKING_DIRECTORY: Example
API_LEVEL: 34
concurrency:
group: android-e2e-${{ github.ref }}
cancel-in-progress: true
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@main
with:
tool-cache: true
android: false
- name: Set up JDK 17
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: '17'
distribution: 'zulu'
cache: 'gradle'
- name: Use Node.js 18
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 18
cache: 'yarn'
Expand All @@ -48,23 +54,40 @@ jobs:
name: Reinstall node dependencies
working-directory: ${{ env.WORKING_DIRECTORY }}
run: yarn
- name: Install AVD dependencies
run: |
sudo apt update
sudo apt-get install -y libpulse0 libgl1
- name: Build app
working-directory: ${{ env.WORKING_DIRECTORY }}
run: yarn build-e2e-android
- name: Enable KVM
run: |
echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
sudo udevadm control --reload-rules
sudo udevadm trigger --name-match=kvm
Comment on lines +64 to +68
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be best to understand why kvm is needed here and what do we do here 😄

But if it works I guess we're just fine w/o it 🤷🏻‍♂️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing the workflow without it right now 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used by android-emulator-runner and it's necessary. I'm bringing it back

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the caches I asked in the main message?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my case AVD cache helped to shave off 1-2 minutes when I boot the emulator. Curious to see the result in your project 👀

- name: AVD cache
uses: actions/cache@v4
id: avd-cache
with:
path: |
~/.android/avd/*
~/.android/adb*
key: avd-${{ env.API_LEVEL }}
- name: Run emulator and tests
uses: reactivecircus/android-emulator-runner@v2
with:
working-directory: ${{ env.WORKING_DIRECTORY }}
api-level: 31
target: aosp_atd
api-level: ${{ env.API_LEVEL }}
target: default
profile: pixel_2
ram-size: '4096M'
disk-size: '10G'
disable-animations: false
avd-name: e2e_emulator
arch: x86_64
script: yarn test-e2e-android
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: android-fail-screen-shots
Expand Down
Loading