-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: moved android e2e to ubuntu #2196
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b263064
chore: moved android e2e to ubuntu
alduzy 8760c35
feat: added Enable KVM group perms step
alduzy 85c80f2
feat: added free disk space step
alduzy 981585a
fix: remove added cache step
alduzy 8ff9958
fix: emulator runner version
alduzy 05a9e44
changed api level
alduzy 9807b8f
feat: added worklfow caching
alduzy da7c56d
fix: remove added yarn cache
alduzy bdae6ea
feat: revert gradle cache, changed tests target
alduzy b891686
fix: added Install AVD dependencies step
alduzy 74ef98a
fix: changed target
alduzy d98dd2a
Merge remote-tracking branch 'origin/main' into @alduzy/move-android-…
alduzy 7bb727d
removed extra AVD step
alduzy 6d7bbd9
remove extra KVM step (try)
alduzy 91f3433
fix: bring back KVM
alduzy 8662f1f
chore: bump android api
alduzy 8fb71a1
feat: added AVD cache
alduzy f864103
added install AVD dependencies step
alduzy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be best to understand why
kvm
is needed here and what do we do here 😄But if it works I guess we're just fine w/o it 🤷🏻♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing the workflow without it right now 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used by android-emulator-runner and it's necessary. I'm bringing it back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great find!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the caches I asked in the main message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my case AVD cache helped to shave off 1-2 minutes when I boot the emulator. Curious to see the result in your project 👀