Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused code in podspec #2241

Merged
merged 1 commit into from
Jul 12, 2024
Merged

chore: remove unused code in podspec #2241

merged 1 commit into from
Jul 12, 2024

Conversation

WoLewicki
Copy link
Member

Description

Since we support RN from 0.71, and install_modules_dependencies is already available there, we can remove the unused code.

tboba
tboba approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good! Have you tested if project with RN 0.71 installed works correctly on Paper/Fabric with this change?

@WoLewicki
Copy link
Member Author

Nope

@tboba
Copy link
Member

tboba commented Jul 9, 2024

Let me check that

@tboba
Copy link
Member

tboba commented Jul 9, 2024

Everything seems to work fine there! I think we can proceed.

kkafar
kkafar approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@kkafar kkafar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the code changes do look ok. If we're good down to 0.71 (or even 0.72, as that will be the last version we support with release of 0.75) then we're good here.

Thanks

@tboba tboba merged commit 6219db1 into main Jul 12, 2024
5 checks passed
@tboba tboba deleted the @wolewicki/remove-unused-code branch July 12, 2024 08:51
@WesleyR10 WesleyR10 mentioned this pull request Aug 21, 2024
Open
@shonore shonore mentioned this pull request Aug 22, 2024
Open
@2lambda123 2lambda123 mentioned this pull request Aug 22, 2024
Merged
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Closed
This was referenced Aug 23, 2024
Open
Open
Open
Open
@2lambda123 2lambda123 mentioned this pull request Aug 26, 2024
Merged
This was referenced Aug 27, 2024
Open
Open
Open
Open
Open
Open
Open
@shonore shonore mentioned this pull request Sep 3, 2024
Open
@undrthegraveyard undrthegraveyard mentioned this pull request Sep 4, 2024
Closed
@asraful-cse asraful-cse mentioned this pull request Sep 6, 2024
Open
This was referenced Sep 24, 2024
Open
Open
This was referenced Sep 26, 2024
Open
Open
Open
Open
@Ayush-Bulbule Ayush-Bulbule mentioned this pull request Oct 2, 2024
Merged
@tobistudio tobistudio mentioned this pull request Oct 3, 2024
Open
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
@WoLewicki @ja1ns
chore: remove unused code in podspec (software-mansion#2241)
63a4420 
## Description

Since we support RN from 0.71, and `install_modules_dependencies` is
already available there, we can remove the unused code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciekstosio maciekstosio maciekstosio approved these changes

@tboba tboba tboba approved these changes

@kkafar kkafar kkafar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WoLewicki @tboba @maciekstosio @kkafar