Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused code in podspec #2241

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

WoLewicki
Copy link
Member

Description

Since we support RN from 0.71, and install_modules_dependencies is already available there, we can remove the unused code.

Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good! Have you tested if project with RN 0.71 installed works correctly on Paper/Fabric with this change?

@WoLewicki
Copy link
Member Author

Nope

@tboba
Copy link
Member

tboba commented Jul 9, 2024

Let me check that

@tboba
Copy link
Member

tboba commented Jul 9, 2024

Everything seems to work fine there! I think we can proceed.

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the code changes do look ok. If we're good down to 0.71 (or even 0.72, as that will be the last version we support with release of 0.75) then we're good here.

Thanks

@tboba tboba merged commit 6219db1 into main Jul 12, 2024
5 checks passed
@tboba tboba deleted the @wolewicki/remove-unused-code branch July 12, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants