Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix layout of screen sequence animation #2303

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

tboba
Copy link
Member

@tboba tboba commented Aug 13, 2024

Description

So previously, when there was a production build, screens from screen sequence in hero were wrongly moving into incorrect div. I've wrapped whole sequence into an additional div, so to disallow screens from moving there (somehow it fixes this issue).

Changes

  • Wrapped page with additional divs

Screenshots / GIFs

Before

CleanShot 2024-08-13 at 16 40 24@2x

After

CleanShot 2024-08-13 at 16 39 23@2x

Checklist

  • Ensured that CI passes

Copy link
Contributor

@patrycjakalinska patrycjakalinska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@tboba
Copy link
Member Author

tboba commented Aug 13, 2024

One must imagine sisyphus happy :shipit: :shipit:

@tboba tboba merged commit 29f8ecf into main Aug 13, 2024
1 check passed
@tboba tboba deleted the @tboba/fix-prod-build branch August 13, 2024 14:55
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
## Description

So previously, when there was a production build, screens from screen
sequence in hero were wrongly moving into incorrect div. I've wrapped
whole sequence into an additional div, so to disallow screens from
moving there (somehow it fixes this issue).

## Changes

- Wrapped page with additional divs

## Screenshots / GIFs

### Before

![CleanShot 2024-08-13 at 16 40
24@2x](https://github.com/user-attachments/assets/4dc505df-66e7-40a3-bde9-6d334f384c7e)

### After

![CleanShot 2024-08-13 at 16 39
23@2x](https://github.com/user-attachments/assets/6bee706c-d642-4ef1-9d0f-d70105d711d9)

## Checklist

- [ ] Ensured that CI passes
kkafar pushed a commit that referenced this pull request Oct 25, 2024
## Description

So previously, when there was a production build, screens from screen
sequence in hero were wrongly moving into incorrect div. I've wrapped
whole sequence into an additional div, so to disallow screens from
moving there (somehow it fixes this issue).

## Changes

- Wrapped page with additional divs

## Screenshots / GIFs

### Before

![CleanShot 2024-08-13 at 16 40
24@2x](https://github.com/user-attachments/assets/4dc505df-66e7-40a3-bde9-6d334f384c7e)

### After

![CleanShot 2024-08-13 at 16 39
23@2x](https://github.com/user-attachments/assets/6bee706c-d642-4ef1-9d0f-d70105d711d9)

## Checklist

- [ ] Ensured that CI passes

(cherry picked from commit 29f8ecf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants