Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for dynamic frameworks #2315

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

WoLewicki
Copy link
Member

PR concerning New Architecture support in the library 🎉

We at Software Mansion have been working on improving support for the new architecture for quite a while now. If you need help with anything related to New Architecture, like:

or you just want to ask any questions, hit us up on projects@swmansion.com


Summary

PR adding load method needed for dynamic frameworks to work with the library. See facebook/react-native#37274 for more information.

Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also need to add these methods to RNSScreenFooter and RNSScreenContentWrapper?

@WoLewicki
Copy link
Member Author

Good catch, done!

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Once we land this, we will need to test #2228, since it is possible that the problem will be solved, as Fabric-interop mode will no longer be used.

@WoLewicki WoLewicki changed the title feat: add load method feat: add support for dynamic frameworks Aug 26, 2024
@WoLewicki WoLewicki merged commit 29c98e2 into main Aug 26, 2024
5 checks passed
@WoLewicki WoLewicki deleted the @wolewicki/add-load-method branch August 26, 2024 07:24
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
PR adding load method needed for dynamic frameworks to work with the library. See facebook/react-native#37274 for more information.
kkafar pushed a commit that referenced this pull request Oct 25, 2024
PR adding load method needed for dynamic frameworks to work with the library. See facebook/react-native#37274 for more information.

(cherry picked from commit 29c98e2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants