Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Android)!: overflowing text in native header #2325

Merged
merged 50 commits into from
Oct 8, 2024
Merged

fix(Android)!: overflowing text in native header #2325

merged 50 commits into from
Oct 8, 2024

Commits on Aug 28, 2024

  1. Add repros

    @kkafar
    kkafar committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    81f35b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Play around with fixing things before adding shadownodes

    @kkafar
    kkafar committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c4eeed3 View commit details
    Browse the repository at this point in the history

  2. Add custom shadow node for header subview

    @kkafar
    kkafar committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    6ff7ca0 View commit details
    Browse the repository at this point in the history

  3. Add custom shadow node for header config

    @kkafar
    kkafar committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    6df50f7 View commit details
    Browse the repository at this point in the history

  4. PoC of the solution

    @kkafar
    kkafar committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    9dec6dd View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Fix Android,Paper build issues

    @kkafar
    kkafar committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    7003af1 View commit details
    Browse the repository at this point in the history

  2. Working PoC on Fabric

    @kkafar
    kkafar committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    558a9b6 View commit details
    Browse the repository at this point in the history

  3. Fix import on Android,Fabric

    @kkafar
    kkafar committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    00efd39 View commit details
    Browse the repository at this point in the history

  4. Fix imports on Android,Paper

    @kkafar
    kkafar committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    65cf758 View commit details
    Browse the repository at this point in the history

  5. PoC for Android,Paper

    @kkafar
    kkafar committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    3ca3794 View commit details
    Browse the repository at this point in the history

  6. fix: pass pixel values to shadow node on paper

    @kkafar
    kkafar committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    a7af4b3 View commit details
    Browse the repository at this point in the history

  7. Remove flex: 1 from subview child

    @kkafar
    kkafar committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    42d3316 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Remove redundant logging

    @kkafar
    kkafar committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    3f38c9a View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. PoC: iOS,Paper fix

    @kkafar
    kkafar committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a2a5bab View commit details
    Browse the repository at this point in the history

  2. Bump react-navigation

    @kkafar
    kkafar committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    bee5c84 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Patch crash on iOS when there arent at least two subviews

    @kkafar
    kkafar committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2cd6a5b View commit details
    Browse the repository at this point in the history

  2. Patch for native Android code

    @kkafar
    kkafar committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ee956a5 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Enable cpp part of fix for iOS

    @kkafar
    kkafar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    556b63d View commit details
    Browse the repository at this point in the history

  2. Multiple things (see commit details) 

    * Add PoC for Fabric fix (not entirely working yet)
* Move header inset updating code to the header config - it didn't make
  much sense for this code to live in screen.
* Moved all the code fix from `viewDidLayoutSubviews` to separate method
* Added few helper methods on HeaderConfig
    @kkafar
    kkafar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    05c17f9 View commit details
    Browse the repository at this point in the history

  3. Update Example pods due to new files

    @kkafar
    kkafar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    fb3331b View commit details
    Browse the repository at this point in the history

  4. Update FabricExample pods due to new files

    @kkafar
    kkafar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b95aa73 View commit details
    Browse the repository at this point in the history

  5. Update test example

    @kkafar
    kkafar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c87dec2 View commit details
    Browse the repository at this point in the history

  6. TOREVERT: build RN from source in Example on Android

    @kkafar
    kkafar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    32e0984 View commit details
    Browse the repository at this point in the history

  7. TO PARTIAL REVERT! Update react-navigation (see details) 

    in this commit react-navigation is on v6 branch.
You need to change it back to v7 and apply changes to the v7 branch.
This is the reference PR to v6:

react-navigation/react-navigation#12135
    @kkafar
    kkafar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e99bdec View commit details
    Browse the repository at this point in the history

  8. Detect barbutton view width (at least on iOS 17) instead of hardcoded… 

    … value
    @kkafar
    kkafar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    12d685d View commit details
    Browse the repository at this point in the history

  9. Cleanup iOS code a bit

    @kkafar
    kkafar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    04313b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Add docs for the UINavigationBar+RNSUtility category methods

    @kkafar
    kkafar committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    92157db View commit details
    Browse the repository at this point in the history

  2. Reset state properly before moving component to recycle pool

    @kkafar
    kkafar committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    700d079 View commit details
    Browse the repository at this point in the history

  3. Update example

    @kkafar
    kkafar committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bf544c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Merge branch 'main' into @kkafar/shopify-not-truncated-title-with-hea… 

    …derright-custom-shadownodes-2
    @kkafar
    kkafar committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7a7f324 View commit details
    Browse the repository at this point in the history

  2. chore: update example

    @kkafar
    kkafar committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c54be5d View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. fix: fix condition for isDisplayingBackButton

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a31ed53 View commit details
    Browse the repository at this point in the history

  2. fix: fix condition for isDisplayingBackButton

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6e9fd4a View commit details
    Browse the repository at this point in the history

  3. refactor: start moving styles for header components from react-naviga… 

    …tion to screens
    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    78fc482 View commit details
    Browse the repository at this point in the history

  4. refactor: do not force consumer to set styles on header config

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3b55907 View commit details
    Browse the repository at this point in the history

  5. refactor: do not force consumer to set styles on header subview center

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    667fa2d View commit details
    Browse the repository at this point in the history

  6. chore: revert building RN in Example from source

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    9a5e5ac View commit details
    Browse the repository at this point in the history

  7. chore: revert changes in app.tsx

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3233ed1 View commit details
    Browse the repository at this point in the history

  8. chore: update pods in examples

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    0d22970 View commit details
    Browse the repository at this point in the history

  9. refactor: improve code in FabricEnabledConfigViewGroup

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    dc2fec2 View commit details
    Browse the repository at this point in the history

  10. fix: add FabricEnabledHeaderConfigViewGroup to blacklist for archit… 

    …ecture-consistecy checks
    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    01df1bc View commit details
    Browse the repository at this point in the history

  11. chore: add comment on shadow node creation

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    bcbef52 View commit details
    Browse the repository at this point in the history

  12. chore: add comment on PaddingBundle

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    863102e View commit details
    Browse the repository at this point in the history

  13. refactor: rename FabricEnabledConfigViewGroup -> FabricEnabledHeaderC… 

    …onfigViewGroup
    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    082075b View commit details
    Browse the repository at this point in the history

  14. chore: restore contents of App.tsx

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    700906e View commit details
    Browse the repository at this point in the history

  15. chore: remove redundant whitespace

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    90c9e2c View commit details
    Browse the repository at this point in the history

  16. chore: remove TestHeaderRight

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a75b68e View commit details
    Browse the repository at this point in the history

  17. chore: iOS cleanup part 1

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    b2ae330 View commit details
    Browse the repository at this point in the history

  18. fix: fix consistency check

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    218de30 View commit details
    Browse the repository at this point in the history

  19. chore: bump react-navigation to main (with requried changes)

    @kkafar
    kkafar committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e1e68e1 View commit details
    Browse the repository at this point in the history