-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support for 0.76-rc.6 #2407
chore: add support for 0.76-rc.6 #2407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's bump to 0.76.0-rc.6, it has been released few hours ago.
Make sure in upgrade helper that no mor changes are needed, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes seems good! I have some suggestions / nitpicks.
@@ -54,7 +54,7 @@ jobs: | |||
id: install_pods | |||
continue-on-error: true | |||
working-directory: ${{ env.WORKING_DIRECTORY }}/ios | |||
run: RCT_NEW_ARCH_ENABLED=1 pod install | |||
run: pod install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should keep this explicit, especially that we've had this already in place.
The same for RCT_NEW_ARCH_ENABLED=0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I checked Podfile value overrides command anyway
Bumped to rc.6 in: 7765e6e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're looking good here! Thanks!
This PR bumps example apps to 0.76.0-rc.6. Removed outdated patches for react-native-reanimated and react-native-gesture-handler. Add patch for react-native-safe-area-context. Reanimated is provided as `.tgz` it should be released with the necessary fixes any day now. Tested also on 0.75.4 both paper and fabric seems to work fine. To run it go to `Example` / `FabricExample`: ``` yarn npx patch-package ```
This PR bumps example apps to 0.76.0-rc.6. Removed outdated patches for react-native-reanimated and react-native-gesture-handler. Add patch for react-native-safe-area-context. Reanimated is provided as `.tgz` it should be released with the necessary fixes any day now. Tested also on 0.75.4 both paper and fabric seems to work fine. To run it go to `Example` / `FabricExample`: ``` yarn npx patch-package ``` (cherry picked from commit b331ad8)
Description
This PR bumps example apps to 0.76.0-rc.6.
Removed outdated patches for react-native-reanimated and react-native-gesture-handler.
Add patch for react-native-safe-area-context.
Reanimated is provided as
.tgz
it should be released with the necessary fixes any day now.Tested also on 0.75.4 both paper and fabric seems to work fine.
To run it go to
Example
/FabricExample
: