Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for 0.76-rc.6 #2407

Merged
merged 16 commits into from
Oct 21, 2024

Conversation

maciekstosio
Copy link
Contributor

@maciekstosio maciekstosio commented Oct 15, 2024

Description

This PR bumps example apps to 0.76.0-rc.6.
Removed outdated patches for react-native-reanimated and react-native-gesture-handler.
Add patch for react-native-safe-area-context.
Reanimated is provided as .tgz it should be released with the necessary fixes any day now.
Tested also on 0.75.4 both paper and fabric seems to work fine.

To run it go to Example / FabricExample:

#  rm -rf node_modules/ android/build android/app/build # might not be necessary 
yarn
npx patch-package

@maciekstosio maciekstosio changed the title chore: bump example apps to 0.76-rc4 chore: bump example apps to 0.76-rc.5 Oct 16, 2024
@maciekstosio maciekstosio marked this pull request as ready for review October 18, 2024 10:33
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bump to 0.76.0-rc.6, it has been released few hours ago.

Make sure in upgrade helper that no mor changes are needed, please

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seems good! I have some suggestions / nitpicks.

@@ -54,7 +54,7 @@ jobs:
id: install_pods
continue-on-error: true
working-directory: ${{ env.WORKING_DIRECTORY }}/ios
run: RCT_NEW_ARCH_ENABLED=1 pod install
run: pod install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should keep this explicit, especially that we've had this already in place.

The same for RCT_NEW_ARCH_ENABLED=0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I checked Podfile value overrides command anyway

Example/ios/Podfile Show resolved Hide resolved
Example/package.json Show resolved Hide resolved
FabricExample/ios/Podfile Show resolved Hide resolved
android/src/main/jni/CMakeLists.txt Show resolved Hide resolved
@maciekstosio maciekstosio changed the title chore: bump example apps to 0.76-rc.5 chore: bump example apps to 0.76-rc.6 Oct 18, 2024
@maciekstosio
Copy link
Contributor Author

maciekstosio commented Oct 18, 2024

Bumped to rc.6 in: 7765e6e

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're looking good here! Thanks!

Example/package.json Show resolved Hide resolved
@maciekstosio maciekstosio changed the title chore: bump example apps to 0.76-rc.6 chore: add support for 0.76-rc.6 Oct 21, 2024
@maciekstosio maciekstosio merged commit b331ad8 into main Oct 21, 2024
7 checks passed
@maciekstosio maciekstosio deleted the @maciekstosio/Bump-example-apps-to-0.76.0-rc4 branch October 21, 2024 09:35
maciekstosio added a commit that referenced this pull request Oct 24, 2024
This PR bumps example apps to 0.76.0-rc.6.
Removed outdated patches for react-native-reanimated and
react-native-gesture-handler.
Add patch for react-native-safe-area-context.
Reanimated is provided as `.tgz` it should be released with the
necessary fixes any day now.
Tested also on 0.75.4 both paper and fabric seems to work fine.

To run it go to `Example` / `FabricExample`:

```
yarn
npx patch-package

```
kkafar pushed a commit that referenced this pull request Oct 25, 2024
This PR bumps example apps to 0.76.0-rc.6.
Removed outdated patches for react-native-reanimated and
react-native-gesture-handler.
Add patch for react-native-safe-area-context.
Reanimated is provided as `.tgz` it should be released with the
necessary fixes any day now.
Tested also on 0.75.4 both paper and fabric seems to work fine.

To run it go to `Example` / `FabricExample`:

```
yarn
npx patch-package

```

(cherry picked from commit b331ad8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants