feat!: remove shouldUseActivityState flag
#2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've checked - this is no longer used in neither native-stack v5, react-navigation/native-stack@v6 nor v7.
alduzy
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
LGTM!
I found a commit that removed it from navigation: react-navigation/react-navigation@64bcd58
WoLewicki
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
shouldUseActivityStateflag from public API (and in general).The flag was initially introduced in #624, as a mean for downstream library developers
to differentiate between different screen versions. This was introduced over 4 years ago
and currently does not serve any role in
react-navigationimplementation.Changes
shouldUseActivityStateflag from public API,compatibilityFlagsobject.Test code and steps to reproduce
N/A
Checklist