fix: header config missing ref #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
reviewed
Oct 22, 2024
|
@kkafar I adjusted it just so it can be used in a forwardRef, but generally speaking you're right. I'll change it in both PRs to match this convention. |
maciekstosio
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
ScreenStackHeaderConfiginto a forwardRef.This is needed if you want to attach
refto it, which react-native-reanimated needs to do here in order to migrate to v4, since the header config is now a function component and cannot be used directly anymore.Without this change the app crashes with
Cannot read property 'getScrollableNode' of null.Related PR: software-mansion/react-native-reanimated#6622
Checklist