Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add hero support for 4k monitors #2460

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

patrycjakalinska
Copy link
Contributor

@patrycjakalinska patrycjakalinska commented Oct 29, 2024

Description

Before on 4k monitors it was impossible to click on navbar due to hero svg overlapping with it. In this PR we adjusted styles for this to work.

image

@patrycjakalinska patrycjakalinska marked this pull request as ready for review October 30, 2024 10:13
@kkafar
Copy link
Member

kkafar commented Oct 31, 2024

I won't have 4K monitor for the rest of the week ;D

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good and promising though!

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes, works as expected, thanks!

@kkafar kkafar merged commit 6a95fe7 into main Nov 13, 2024
1 check passed
@kkafar kkafar deleted the @patrycjakalinska/landing-hero-adjustment branch November 13, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants