fix(Android): missing transition events with formSheet presentation #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
commented
Feb 11, 2025
| fun dispatchOnDismissed() = | ||
| reactEventDispatcher?.dispatchEvent(ScreenDismissedEvent(reactSurfaceId, screen.id)) | ||
|
|
||
| fun dispatchTransitionProgress(progress: Float, isExitAnimation: Boolean, isGoingForward: Boolean) { |
There was a problem hiding this comment.
Not entirely sure of isGoingForward semantics here. This is something to retrospect later.
There was a problem hiding this comment.
Created ticket on board for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aligns* events received in element tree between Android and iOS for screens with
presentation: 'formSheet'.* almost aligns - on iOS when natively dismissed
onDismissedandonDisappear/transitionEndwill be received, whereas on Android it will be onlyonDismissedfor now.Adding support for
onDisappear/transitionEndrequires wider changes in logic which I don't want in incoming 4.7.0 release.Changes
formSheetanimations based on custom animators now have listener set, which emmits appropriate events bypassing "regular" view emitting infrastructure.I've found that
ScreenFragment.onViewAnimation{Start,End}methods do not work for some reason (isResumedis false for form sheet) with the sheets, therefore I bypassed it for now.Test code and steps to reproduce
TestAndroidTransition+ add logs inNativeStackViewinreact-navigationto see when events are received (or attach appropriate listeners).Checklist