Update example to react-navigation 5.x #470
Conversation
|
Well, I'm wondering if we can somehow have both of them included using some aliases for libraries |
|
We for sure want to have the older version of react-navigation included in the Example app. |
|
After some discussion, we decided to update the Example app to contain the v5. @michaelgmcd could you update the packages to the newest version or would you like me to do all the stuff required and tag you in a PR with these? |
|
I can take care of it. Mind not get to it until this weekend though. |
|
Still have this on my radar. Will get to it when I can. |
|
I am going to release a new version soon and would love to have it merged before. Is it possible for you to finish the PR in the next few days? |
|
Working on this now. |
|
Rebased and tested. This should be good to go! |
|
Good job! Thanks for your contribution! |
Not sure if we want to merge this (yet) since it replaces createNativeStackNavigator with the WIP native-stack.
I've tested all of the screens in the example and they work as expected. Not sure if we want to clean up the nesting of headers, but it does make navigating around and debugging simpler.