Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example to react-navigation 5.x #470

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Update example to react-navigation 5.x #470

merged 1 commit into from
Aug 1, 2020

Conversation

michaelgmcd
Copy link
Contributor

Not sure if we want to merge this (yet) since it replaces createNativeStackNavigator with the WIP native-stack.

I've tested all of the screens in the example and they work as expected. Not sure if we want to clean up the nesting of headers, but it does make navigating around and debugging simpler.

@osdnk
Copy link
Contributor

osdnk commented Apr 21, 2020

Well, I'm wondering if we can somehow have both of them included using some aliases for libraries

@WoLewicki
Copy link
Member

We for sure want to have the older version of react-navigation included in the Example app.

@WoLewicki
Copy link
Member

After some discussion, we decided to update the Example app to contain the v5. @michaelgmcd could you update the packages to the newest version or would you like me to do all the stuff required and tag you in a PR with these?

@michaelgmcd
Copy link
Contributor Author

I can take care of it. Mind not get to it until this weekend though.

@michaelgmcd
Copy link
Contributor Author

Still have this on my radar. Will get to it when I can.

@WoLewicki
Copy link
Member

I am going to release a new version soon and would love to have it merged before. Is it possible for you to finish the PR in the next few days?

@michaelgmcd
Copy link
Contributor Author

Working on this now.

@michaelgmcd
Copy link
Contributor Author

Rebased and tested. This should be good to go!

@WoLewicki
Copy link
Member

Good job! Thanks for your contribution!

Example/package.json Outdated Show resolved Hide resolved
@WoLewicki WoLewicki merged commit 081fd35 into software-mansion:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants